Skip to content

ci: stub required-status-check workflows - #139

Closed
williaby wants to merge 1 commit into
mainfrom
ci/stub-required-checks
Closed

ci: stub required-status-check workflows#139
williaby wants to merge 1 commit into
mainfrom
ci/stub-required-checks

Conversation

@williaby

Copy link
Copy Markdown
Owner

Stubs for williaby-default-branch-baseline ruleset (ID 16198242). Implementations deferred.

Copilot AI review requested due to automatic review settings May 10, 2026 22:24
@coderabbitai

coderabbitai Bot commented May 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 10 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 17ca581c-3193-4c39-ba7a-379cafb9f778

📥 Commits

Reviewing files that changed from the base of the PR and between ca3bfe5 and d0e6f01.

📒 Files selected for processing (1)
  • .github/workflows/dependency-standards-validation.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/stub-required-checks

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow intended to satisfy a required status check for the williaby-default-branch-baseline ruleset (ID 16198242), with the actual validation logic intentionally deferred.

Changes:

  • Introduces a new workflow file for “Dependency and Standards Validation”.
  • Configures the workflow to run on pull_request and on push to main.
  • Implements a placeholder job that always succeeds (prints stub).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@williaby
williaby enabled auto-merge (squash) September 3, 2026 12:41
Adds a placeholder workflow so the williaby-default-branch-baseline
ruleset required status check (ID 16198242) is satisfied while a full
implementation is deferred.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@williaby
williaby force-pushed the ci/stub-required-checks branch from 0250e78 to d0e6f01 Compare September 3, 2026 12:55
@williaby williaby closed this Sep 3, 2026
auto-merge was automatically disabled September 3, 2026 20:17

Pull request was closed

@williaby williaby reopened this Sep 3, 2026
@williaby

williaby commented Sep 3, 2026

Copy link
Copy Markdown
Owner Author

Closing as obsolete. Two independent reasons, and the second is the important one.

1. The gap it was written to fill no longer exists.

This PR was opened on 2026-05-10 to make the required context Dependency & Standards Validation report at all. It already does. A current PR in this repository (#155) shows that context reporting SUCCESS from existing workflows on main, without this file. Merging this would add a third emitter of a context that already has working ones.

2. The job it adds enforces nothing.

The entire job body is:

  dep-standards:
    name: Dependency & Standards Validation
    runs-on: ubuntu-latest
    steps:
      - name: Placeholder
        run: echo "stub"

A required status check whose implementation is echo "stub" cannot fail, so it reports green regardless of the state of the dependencies or standards it claims to validate. That is worse than a missing check: a missing check blocks loudly and gets fixed, while an always-green check looks like coverage and quietly provides none. Anyone reading the branch protection list would reasonably conclude this repository validates dependencies on every PR.

For the record on the mechanics: because GitHub requires every check run sharing a context name to pass, this stub would not actually weaken the existing real gate. So the harm here is not a bypass, it is the misleading signal and the extra always-green run.

What actually blocked this repository, for the record. The real cause of the required checks not reporting was that GitHub had auto-disabled 39 workflows across seven repositories for repository inactivity, including security-analysis.yml, the sole emitter of Security Gate Validation. A disabled workflow never runs and so never reports, which leaves a PR BLOCKED with a fully green check list and nothing in the rollup to explain it. Those workflows have now been re-enabled and re-triggered, which is the fix this PR was reaching for.

The branch ci/stub-required-checks is not deleted, so nothing is lost.

@williaby williaby closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants